make test not working

[kolyshkin]

I tried to run make test for this repo and it's not working

[kir@kir-rhat go-criu]$ make test
mkdir -p image
test/piggie
Child forked, pid -1
test/test dump `pidof piggie` image
CRIU version 31500
panic: runtime error: index out of range [3] with length 3

goroutine 1 [running]:
main.main()
	/home/kir/go/src/github.com/checkpoint-restore/go-criu/test/main.go:79 +0xc88
make: *** [Makefile:28: test] Error 2

One thing I can see is test/piggie is run w/o arguments, while it requires a log file as an argument. The other (secondary) issue is lack of error checking.

I have a feeling I am missing something very obvious here; please help.

[rst0git]

I have a feeling I am missing something very obvious here; please help.

checkpoint/restore of test/piggie requires root privileges.

$ sudo make test
mkdir -p image
test/piggie
Child forked, pid 325139
test/test dump `pidof piggie` image                                                                                                                   
CRIU version 31500                                                                                                                                    
Dumping                                                                                                                                               
TEST PRE DUMP                                                                                                                                         
Success                                                                                                                                               
test/test restore image                                                                                                                               
CRIU version 31500                                                                                                                                    
Restoring                                                                                                                                             
Success                                                                                                                                               
pkill -9 piggie || :

[kolyshkin]

This was caused by not running tests as root, as well as lack of checking in piggie and Makefile.

All this is addressed now:

• test/piggie.c: handle error from clone() #44 test/piggie.c: handle error from clone()
• 93b6a6a (item 2) Fix mixing C and go files, enable golangci-lint (this is part of gha: add golangci-lint job, fix warnings; bump API version #46)

[kolyshkin]

now fixed:

[kir@kir-rhat go-criu]$ make test
mkdir -p image
PID=$(test/piggie/piggie) && { \
test/test dump $PID image && \
test/test restore image; \
pkill -9 piggie; \
}
clone() failed: Operation not permitted
make: *** [Makefile:23: test] Error 1

(it' is more clear now that EPERM is the cause of the failure, and where it comes from)