You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Setting use-config-as-code-from-default-branch property to true will void any possibility of a push/PR on a non-default protected branch overriding some CxFlow properties using the branch's cx.config file. For example, if the default branch's cx.config is filtering Highs and Mediums, by changing it on the protected branch's cx.config file to filter only Highs when the code is pushed is currently impossible.
`
Expected Behavior
Use the protected branch's cx.config file to override the CxFlow configuration property on a push/pr event.
Could be accomplished by having a non-binary way to tell CxFlow what events should trigger the fetch of config-as-code's cx.config from the default branch, by replacing the use-config-as-code-from-default-branch: true|false property with something like:
The default option here should be exclusively for the "delete" event since it's the only event when you usually require a cx.config from the default branch to be fetc since the branch's cx.config code will not be present after the branch is deleted.
This should be the rule for other supported SCMs as well, like when using Azure DevOps' CxFlow configuration property deleteCxProject: true|false that deletes a project when the feature branch is deleted. This should also be changed to something like:
There might be times when using the config-as-code from the default branch might make sense, hence adding the "pushreq" and "pullreq" options
Actual Behavior
As per the request done on #384, the behavior enforces the pick up of cx.config from the default branch every time (push/PR/delete) and not just on deletion as most cases will be based on.
This means that, for example, if one pushes code or opens a PR on a branch that requires a different cx.config, for example, to set a filter to catch only Highs and send them to a bug-tracker, then that will not work and the filter-severity
Reproduction
Execute CxFlow in web mode but add the use-config-as-code-from-default-branch: true option on the GitHub section.
Set a cx.config with overriding properties on a feature branch and push the branch to one of the protected branches,
Check if the overrides weren't applied to the project.
Environment Details
Windows 10, CxFlow 1,6,22
The text was updated successfully, but these errors were encountered:
Description
Setting
use-config-as-code-from-default-branch
property totrue
will void any possibility of a push/PR on a non-default protected branch overriding some CxFlow properties using the branch's cx.config file. For example, if the default branch's cx.config is filtering Highs and Mediums, by changing it on the protected branch's cx.config file to filter only Highs when the code is pushed is currently impossible.`
Expected Behavior
Use the protected branch's cx.config file to override the CxFlow configuration property on a push/pr event.
Could be accomplished by having a non-binary way to tell CxFlow what events should trigger the fetch of config-as-code's cx.config from the default branch, by replacing the
use-config-as-code-from-default-branch: true|false
property with something like:The default option here should be exclusively for the "delete" event since it's the only event when you usually require a cx.config from the default branch to be fetc since the branch's cx.config code will not be present after the branch is deleted.
This should be the rule for other supported SCMs as well, like when using Azure DevOps' CxFlow configuration property
deleteCxProject: true|false
that deletes a project when the feature branch is deleted. This should also be changed to something like:There might be times when using the config-as-code from the default branch might make sense, hence adding the "pushreq" and "pullreq" options
Actual Behavior
As per the request done on #384, the behavior enforces the pick up of cx.config from the default branch every time (push/PR/delete) and not just on deletion as most cases will be based on.
This means that, for example, if one pushes code or opens a PR on a branch that requires a different cx.config, for example, to set a filter to catch only Highs and send them to a bug-tracker, then that will not work and the
filter-severity
Reproduction
use-config-as-code-from-default-branch: true
option on the GitHub section.Environment Details
Windows 10, CxFlow 1,6,22
The text was updated successfully, but these errors were encountered: