Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sarif Format: Use the region "snippet" instead of Location "message" for the affected lines of code. #1253

Open
marcandre-larochelle opened this issue Jul 14, 2023 · 1 comment
Open

Sarif Format: Use the region "snippet" instead of Location "message" for the affected lines of code. #1253

marcandre-larochelle opened this issue Jul 14, 2023 · 1 comment
Labels
enhancement New feature or request Planned For Upcoming releases

Comments

@marcandre-larochelle
Copy link

Describe the problem

The specification has a snippet in the Location object for the affected lines of code, but the Sarif output uses the Location -> message property instead.

Proposed solution

Use the Location -> region -> snippet for the affected code.

Additional details

CxFlow 1.6.40-11
@marcandre-larochelle marcandre-larochelle added the enhancement New feature or request label Jul 14, 2023
@marcandre-larochelle
Copy link
Author

Still applies to 1.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Planned For Upcoming releases
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@itsKedar @marcandre-larochelle