Skip to content
This repository has been archived by the owner on Oct 9, 2024. It is now read-only.

[Alert component] Make it undismissible by default #473

Open
robbieaverill opened this issue Jul 5, 2021 · 1 comment
Open

[Alert component] Make it undismissible by default #473

robbieaverill opened this issue Jul 5, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@robbieaverill
Copy link
Contributor

robbieaverill commented Jul 5, 2021

image
image

This renders an alert which is dismissible, since I didn't tell it not to be, but the close button has no default handler. This feels strange to me, I think we should make it undismissible by default.

@robbieaverill robbieaverill added the enhancement New feature or request label Jul 5, 2021
@ScopeyNZ
Copy link
Contributor

ScopeyNZ commented Jul 5, 2021

Yeah good point. We can maybe be fancy here and use this.$listeners.close to figure it out.

Also, I notice that the click event is bound to the icon and not the button which is wrong, so we should fix that too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants