-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(operator): fix deploying on K8s with operator and TLS #241
Conversation
src/api/kube.ts
Outdated
@@ -759,6 +759,9 @@ export class KubeHelper { | |||
yamlCr.spec.server.cheImageTag = imageAndTag.length === 2 ? imageAndTag[1] : 'latest' | |||
yamlCr.spec.auth.openShiftoAuth = flags['os-oauth'] | |||
yamlCr.spec.server.tlsSupport = flags.tls | |||
if (flags.tls) { | |||
yamlCr.spec.k8s.tlsSecretName = `che-tls` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where this che-tls
value comes from?
What happens, if I put my own value in CheCluster YAML provided by parameter --che-operator-cr-yaml
. To me it seems, that it will be overriden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sleshchenko FYI it doesn't work on CI (format style error) |
@benoitf Thanks! Fixed. |
Signed-off-by: Sergii Leshchenko <[email protected]>
What does this PR do?
fix(operator): fix deploying on K8s with operator and TLS
What issues does this PR fix or reference?
eclipse-che/che#14102