Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update ValidationgWebhookConfiguration #2192

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Conversation

tolusha
Copy link
Collaborator

@tolusha tolusha commented Jul 26, 2022

Signed-off-by: Anatolii Bazko [email protected]

What does this PR do?

  • fix for updating ValidationgWebhookConfiguration
  • set correct namespace for operator service on webhook config
  • handle failed calling webhook error

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#21577

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@tolusha tolusha requested a review from flacatus as a code owner July 26, 2022 13:16
@openshift-ci
Copy link

openshift-ci bot commented Jul 26, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Anatolii Bazko <[email protected]>
@tolusha tolusha merged commit 72bcbab into main Jul 26, 2022
@tolusha tolusha deleted the fixupdatingwebhookconfig branch July 26, 2022 14:44
@che-bot che-bot added this to the 7.52 milestone Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants