Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could we provide a development docker image that is able to build out of box ? #1

Open
qingant opened this issue Sep 1, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@qingant
Copy link

qingant commented Sep 1, 2023

it takes me a day to setup the build environment and it's still not working. Clickhouse provided a clickhouse/binary-builder docker images for ci/cd which would also help developer to setup an environment . Wondering if we could do that for chdb.

@lmangani
Copy link
Contributor

lmangani commented Sep 1, 2023

Hello @qingant this is a good initiative which could benefit community input and cooperation indeed!

As you know we only use GitHub actions to build chdb. The same environment used in the actions should work to build locally with docker. I think the clickhouse builder could possibly be used to build chdb with minor changes, but I never attempted to do so. Could you clarify more details about your build setup and issue?

@lmangani lmangani added enhancement New feature or request help wanted Extra attention is needed labels Sep 1, 2023
@qingant
Copy link
Author

qingant commented Sep 2, 2023

thanks @lmangani
I tried with clickhouse/binary-builder, installed python3-pip, cmake, ninja-build. and run pip install -U pip setuptools -e .

then I got this:

      CMake Error at contrib/cyrus-sasl-cmake/CMakeLists.txt:79 (target_link_libraries):
        Target "_sasl2" links to:

          ch_contrib::krb5

@lmangani
Copy link
Contributor

lmangani commented Sep 2, 2023

@qingant alright, I'll try to sketch a dedicated chdb docker builder mimicking the action builder and post updates

@lmangani
Copy link
Contributor

lmangani commented Sep 2, 2023

@qingant the test builder seems to work fine. Could you check and confirm? https://github.com/lmangani/chdb-builder

The builder includes an image with all the dev requirements and a script to build chdb and the matching python wheel.

@lmangani lmangani self-assigned this Sep 2, 2023
@lmangani lmangani removed the help wanted Extra attention is needed label Sep 2, 2023
@lmangani
Copy link
Contributor

lmangani commented Sep 2, 2023

Issue moved to chdb-io/chdb-builder

@lmangani lmangani closed this as completed Sep 2, 2023
@lmangani lmangani transferred this issue from chdb-io/chdb Sep 2, 2023
@lmangani lmangani reopened this Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants