Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create tests for Crisp services #688

Open
2 tasks
annarhughes opened this issue Oct 28, 2024 · 3 comments
Open
2 tasks

Create tests for Crisp services #688

annarhughes opened this issue Oct 28, 2024 · 3 comments
Assignees
@ciaracade
Labels
complexity: moderate Time needed to do this ticket will be moderate e.g. 1-2 days good first issue Good for newcomers priority: soon Should be prioritized soon. software testing Software testing

Comments

@annarhughes
Copy link
Member

Overview

Create tests for new crisp functionality in two new services CrispService and CrispListenerService

Action Items

Resources

This functionality was added (partially refactored) in #673. Anna attempted to create tests building on AI suggestions, however the mocking was not working correctly. There is an open PR #687 with the attempted tests which can be used as a base/inspiration for the tests, however feel free to restart them entirely.
@annarhughes annarhughes added good first issue Good for newcomers complexity: moderate Time needed to do this ticket will be moderate e.g. 1-2 days software testing Software testing priority: soon Should be prioritized soon. labels Oct 28, 2024
@ciaracade
Copy link

Hi, I'd like to work on this issue. However, the links to CrispService and CrispListenerService are returning 404. is this issue corresponding to folders crisp and crisp-listener in this path?

@github-actions GitHub Actions
Copy link

Thank you @ciaracade you have been assigned this issue!
Please follow the directions in our Contributing Guide. We look forward to reviewing your pull request. ✨

Support Chayn's mission? ⭐ Please star this repo to help us find more contributors like you!
Learn more about our impact and sign-up for our volunteer programsto join our mission!. 🌸

@kyleecodes
Copy link
Member

Hi, I'd like to work on this issue. However, the links to CrispService and CrispListenerService are returning 404. is this issue corresponding to folders crisp and crisp-listener in this path?

@annarhughes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ciaracade ciaracade

Labels
complexity: moderate Time needed to do this ticket will be moderate e.g. 1-2 days good first issue Good for newcomers priority: soon Should be prioritized soon. software testing Software testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@annarhughes @kyleecodes @ciaracade