Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requestId and sessionId to logs #532

Open
4 tasks
eleanorreem opened this issue Jul 18, 2024 · 3 comments
Open
4 tasks

Add requestId and sessionId to logs #532

eleanorreem opened this issue Jul 18, 2024 · 3 comments
Labels
complexity: advanced Time needed to do this ticket will be large e.g. 2-3+ days feature/enhancement New feature or request help wanted Extra attention is needed javascript Pull requests that update Javascript code priority: soon Should be prioritized soon. state: approved Ready to go. Not blocked or pending.
Milestone

Comments

@eleanorreem
Copy link
Contributor

Overview

We currently don't log request IDs or session IDs in our logs. These would be hugely helpful with debugging. Every time we call logger.log or logger.error, the output should be decorated with both requestIds and sessionIds. We are currently refactoring/ improving our logs so any suggestions for improving are welcome.

Action Items

Resources/Instructions

@eleanorreem eleanorreem added feature/enhancement New feature or request help wanted Extra attention is needed complexity: advanced Time needed to do this ticket will be large e.g. 2-3+ days priority: soon Should be prioritized soon. state: approved Ready to go. Not blocked or pending. javascript Pull requests that update Javascript code labels Jul 18, 2024
@kyleecodes kyleecodes added this to the 02. Roadmaps milestone Jul 18, 2024
@kyleecodes kyleecodes moved this to To-Do Bloom Backend in Chayn Tech Volunteer Advancement Jul 18, 2024
@chinmaym07
Copy link

@eleanorreem can I try my hands on this ?

Copy link

Thank you @chinmaym07 you have been assigned this issue!
Please follow the directions in our Contributing Guide. We look forward to reviewing your pull request shortly ✨


Support Chayn's mission? ⭐ Please star this repo to help us find more contributors like you!
Learn more about Chayn here and explore our projects. 🌸

@github-actions github-actions bot added the stale This issue or PR is inactive. label Sep 16, 2024
@kyleecodes kyleecodes removed the stale This issue or PR is inactive. label Oct 22, 2024
@leoseg
Copy link
Contributor

leoseg commented Nov 26, 2024

Hi @chinmaym07 are you still working at this? If not I would like to pick up the issue :) As I see the logging.interceptor already logs the user id of the request as well as the IP, what exactly would the request-ID be? About logging the origin IP of the request, I'm not sure if this could be a privacy issue or what do you think about this?:) Also I there is already a session and session-user but as far as I understand those have different meanings than web sessions, here is a solution for sessions which could the already existing Firebase, maybe this would be a solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: advanced Time needed to do this ticket will be large e.g. 2-3+ days feature/enhancement New feature or request help wanted Extra attention is needed javascript Pull requests that update Javascript code priority: soon Should be prioritized soon. state: approved Ready to go. Not blocked or pending.
Projects
None yet
Development

No branches or pull requests

4 participants