Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't trigger the zoom on legends area #772

Merged
merged 3 commits into from
Nov 16, 2024
Merged

Don't trigger the zoom on legends area #772

merged 3 commits into from
Nov 16, 2024

Conversation

ikkala
Copy link
Contributor

@ikkala ikkala commented Jul 13, 2023

Fixes #256

@ikkala ikkala marked this pull request as ready for review July 13, 2023 13:41
@zloveless
Copy link

Any movement on merging this? Is this plugin actively being developed or maintained?

@zloveless
Copy link

zloveless commented May 14, 2024

@igorlukanin @etimberg @kurkle @nnnick @simonbrunel This plugin doesn't seem to be maintained. Is there anyone from the chart.js project that would be willing to be the required PR approver so the community can continue to contribute to it?

edit: I tried this fix, and it works.

@trullock
Copy link
Contributor

trullock commented Oct 1, 2024

This is merged into my fork at https://github.com/trullock/chartjs-plugin-zoom which is published on npm as @trullock/chartjs-plugin-zoom, as this fork seems abandoned

@ikkala
Copy link
Contributor Author

ikkala commented Oct 1, 2024

This is merged into my fork at https://github.com/trullock/chartjs-plugin-zoom which is published on npm as @trullock/chartjs-plugin-zoom, as this fork seems abandoned

@trullock Cool! And good that there's alternative fork in life now.

@kurkle kurkle closed this Nov 14, 2024
@kurkle kurkle reopened this Nov 14, 2024
src/handlers.js Outdated Show resolved Hide resolved
@kurkle kurkle closed this Nov 16, 2024
@kurkle kurkle reopened this Nov 16, 2024
kurkle
kurkle previously approved these changes Nov 16, 2024
@kurkle kurkle merged commit 4c794cb into chartjs:master Nov 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zoom triggered when hiding/showing series by clicking legend
5 participants