Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing modifierKey properties to Options #502

Merged
merged 2 commits into from
May 7, 2021
Merged

Add missing modifierKey properties to Options #502

merged 2 commits into from
May 7, 2021

Conversation

jbelien
Copy link
Contributor

@jbelien jbelien commented May 7, 2021

  • Missing modifierKey to PanOptions
  • Missing wheelModifierKey to ZoomOptions

@jbelien
Add missing properties to Options
a3b5a3c 
- Missing `modifierKey` to `PanOptions`
- Missing `wheelModifierKey` to `ZoomOptions`
kurkle
kurkle requested changes May 7, 2021
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[test-lint] [lint-types] /home/runner/work/chartjs-plugin-zoom/chartjs-plugin-zoom/types/options.d.ts
[test-lint] [lint-types] 51:1 error Trailing spaces not allowed no-trailing-spaces

@jbelien
Update options.d.ts
51bea76 
Apply lint fix (remove trailing spaces).
@kurkle kurkle merged commit e0973e0 into chartjs:master May 7, 2021
@kurkle
Copy link
Member

kurkle commented May 7, 2021

Thanks @jbelien

@jbelien jbelien deleted the patch-1 branch May 7, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
bug types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbelien @kurkle