Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes zoom.threshold default to 0 #461

Merged
merged 1 commit into from
Apr 25, 2021
Merged

Changes zoom.threshold default to 0 #461

merged 1 commit into from
Apr 25, 2021

Conversation

stockiNail
Copy link
Contributor

@stockiNail stockiNail commented Apr 25, 2021 •
edited
Loading

Reading the code, I have seen that threshold options for zoom, is initialized to 0:

chartjs-plugin-zoom/src/handlers.js

Line 82 in eded389

const zoomThreshold = zoomOptions.threshold || 0;

Therefore I think the default could be document to 0, if I'm not wrong.

@kurkle kurkle merged commit 5e10fa8 into chartjs:master Apr 25, 2021
@kurkle
Copy link
Member

kurkle commented Apr 25, 2021

Thanks @stockiNail

@stockiNail stockiNail deleted the changeThresholdDefault branch April 25, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stockiNail @kurkle