-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to logical entities #452
Conversation
kurkle
commented
Apr 15, 2021
•
edited
Loading
edited
Size Change: -127 B (-1%) Total Size: 15.4 kB
|
Edit: does not look like I can get git to detect moved functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome refactoring! 👏
I've found an issue in the zoom-time
sample. The chart disappears when dragging, and there are console errors:
Uncaught TypeError: chartInstance.$zoom._options is undefined
beforeDatasetsDraw http://127.0.0.1:8080/dist/chartjs-plugin-zoom.js:688
callback http://127.0.0.1:8080/node_modules/chart.js/dist/chart.js:796
...
Thanks @jledentu, did not go through the samples myself. I had not completed the beforeDatasetsDraw hook refactoring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, congrats