Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-zoomable charts eating scroll events #429

Merged
merged 2 commits into from
Mar 9, 2021
Merged

Fix non-zoomable charts eating scroll events #429

merged 2 commits into from
Mar 9, 2021

Conversation

jacopotediosi
Copy link
Contributor

No description provided.

jacopotediosi added a commit to jacopotediosi/Unimia-stats that referenced this pull request Feb 27, 2021
Switched to a local manually edited version of chartjs-plugin-zoom 0.7.7 waiting for the merge of chartjs/chartjs-plugin-zoom#429
@kurkle
Copy link
Member

kurkle commented Mar 8, 2021

You need to fix these lint errorrs:

[test-lint] 477:1 error Trailing spaces not allowed no-trailing-spaces
[test-lint] 533:9 error 'zoomOptions' is already declared in the upper scope no-shadow
[test-lint] 567:9 error 'panOptions' is already declared in the upper scope no-shadow

@jacopotediosi
Copy link
Contributor Author

You need to fix these lint errorrs:

[test-lint] 477:1 error Trailing spaces not allowed no-trailing-spaces
[test-lint] 533:9 error 'zoomOptions' is already declared in the upper scope no-shadow
[test-lint] 567:9 error 'panOptions' is already declared in the upper scope no-shadow

Done

@kurkle
Copy link
Member

kurkle commented Mar 9, 2021

Needs a rebase too (tabs to spaces change)

@jacopotediosi
Copy link
Contributor Author

Needs a rebase too (tabs to spaces change)

Done

@kurkle
Copy link
Member

kurkle commented Mar 9, 2021

Thanks, looks like the eslint config is a bit strict:

334:10 error Method 'start' has too many statements (34). Maximum allowed is 30 max-statements

Could you add max-statements: ["warn", 30] under the rules in .eslintrc.yml?

@jacopotediosi
Copy link
Contributor Author

Thanks, looks like the eslint config is a bit strict:

334:10 error Method 'start' has too many statements (34). Maximum allowed is 30 max-statements

Could you add max-statements: ["warn", 30] under the rules in .eslintrc.yml?

Done

@kurkle kurkle added the bug label Mar 9, 2021
@kurkle kurkle changed the title Fix non-zoomable charts eating scroll events #289 and #311 Fix non-zoomable charts eating scroll events Mar 9, 2021
@kurkle kurkle merged commit df5b65e into chartjs:master Mar 9, 2021
@kurkle
Copy link
Member

kurkle commented Mar 9, 2021

Thanks @jacopotediosi

@jacopotediosi jacopotediosi deleted the patch-2 branch March 9, 2021 13:35
ndrake pushed a commit to ndrake/chartjs-plugin-zoom that referenced this pull request Apr 1, 2021
* Fix non-zoomable charts eating scroll events

(cherry picked from commit df5b65e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants