Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The enum UpdateModeEnum is the same name as Chartjs enum name and the typescript is broken. #745

Closed
luisrodriguesds opened this issue Mar 21, 2023 · 2 comments

Comments

@luisrodriguesds
Copy link

Whem I installed the chartjs and zoom plugin in this version

image

the typescript is broken because of this error:

image

So, I needed to change manually the names of this enum at the node_modules\chartjs-plugin-zoom\types\index.d.ts file, like this:
image

Then, the typescript stopped to complain.

Should I create a PR for this?

Thank you!

@kurkle
Copy link
Member

kurkle commented Mar 22, 2023

You could create the version bump to 2.0.1 pr instead (I just can't do it myself right now, but can do the release after the bump)

@shrujalshah28
Copy link
Contributor

@kurkle #746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants