Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not use passive listeners to improve scrolling performance #717

Closed
rabinadk1 opened this issue Jan 4, 2023 · 3 comments
Closed

Does not use passive listeners to improve scrolling performance #717

rabinadk1 opened this issue Jan 4, 2023 · 3 comments

Comments

@rabinadk1
Copy link

I got this during the diagnostics from the Chrome Lighthouse.

Consider marking your touch and wheel event listeners as passive to improve your page's scroll performance. Learn more.
@Sergiobop
Copy link

+1

@estanglerbm
Copy link

wheelPreconditions() can call preventDefault().

Hammer.js (for touch events) also can call preventDefault(). Don't know if CSS touch-action + touchAction = auto would be a future possibility.

Maybe all this doesn't matter with latest browsers if they default these events to passive, anyway.

@kurkle
Copy link
Member

kurkle commented Nov 17, 2024

fixed by #856

@kurkle kurkle closed this as completed Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kurkle @rabinadk1 @Sergiobop @estanglerbm