Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Margins/padding causes drag zoom to be inaccurate #38

Closed
Skuhoo opened this issue Sep 19, 2016 · 8 comments
Closed

Margins/padding causes drag zoom to be inaccurate #38

Skuhoo opened this issue Sep 19, 2016 · 8 comments

Comments

@Skuhoo
Copy link

Skuhoo commented Sep 19, 2016

When the canvas element is offset usings margins/padding the "selection" you make while drag zooming becomes inaccurate.

This is the zoom-time sample page with the body's left margin set to 100:
image

@etimberg
Copy link
Member

Thanks for reporting this @Skuhoo

@gcmestre
Copy link

This problem also occurs with angular material side bar.

etimberg added a commit that referenced this issue Oct 18, 2016
#38: Fix drag zoom inaccuracy by offsetting X coordinates
@niutski
Copy link
Contributor

niutski commented Oct 18, 2016

Could a new (minor?) release be made with the fix please?

@etimberg
Copy link
Member

@niutski I will try and do this tonight

@niutski
Copy link
Contributor

niutski commented Oct 18, 2016

@etimberg cheers!

@etimberg
Copy link
Member

Fixed in #48

@etimberg
Copy link
Member

@niutski fixed in v0.3.0 which I've released. Would you be interested in helping to maintain the zoom plugin? I thought I'd ask since you were quick to fix the merge conflict and get that change merged

@niutski
Copy link
Contributor

niutski commented Oct 19, 2016

@etimberg I can help out when possible :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants