Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Chart js 3.0 #376

Closed
stockiNail opened this issue Aug 11, 2020 · 6 comments · Fixed by #390
Closed

Compatibility with Chart js 3.0 #376

stockiNail opened this issue Aug 11, 2020 · 6 comments · Fixed by #390

Comments

@stockiNail
Copy link
Contributor

Do you have any plans to add next version compatible with Chart.Js@next(3.0)?

@benmccann
Copy link
Collaborator

At some point, but I was probably just going to wait for the final Chart.js 3.0 release

@stockiNail
Copy link
Contributor Author

@benmccann I have forked the project and I have planned to work on that next week, if I can finish Intl implementation in my library.
I can try to change it without changing the model, architetture or adding features.
Just a pure porting.
Could you help?
If you are already working in that, I can try to wait for.
Let me know.

@stockiNail
Copy link
Contributor Author

Submitted PR as promsed.
I have tested with CHART.JS dist/master and it should work everything but please have a look.

@KoalaBear84
Copy link

Thanks! How to use?

#390 (comment)

@stockiNail
Copy link
Contributor Author

Thanks! How to use?

#390 (comment)

@KoalaBear84 you don't have to put the plugin.js in <script> as is. Before you should build it and then take the result of build and put in <script>.
This version is not released yet.
Let me add the built plugin (in a zip) here that you can use it (waiting for the release).

chartjs-plugin-zoom.min.zip

You have to use the file chartjs-plugin-zoom.min.js

@KoalaBear84
Copy link

Thanks for your quick response. Tried it and it indeed works as expected. Will await the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants