-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AutoSkip in update #6355
AutoSkip in update #6355
Conversation
28d3df8
to
90b7a47
Compare
90d4cea
to
fed37b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented just some thoughts, nothing really important.
d437234
to
d0d2bfc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still thinking it would be better to let core.layouts
set the dimensions after update
and do the autoSkip in _configure
(function name could maybe be better).
|
019d7be
to
642d66f
Compare
I've rebased this PR |
Needs to be rebased. Also I don't like the todo. I'd remove it (or at least add something about v3 so new devs don't waste their time doing it in v2) |
0b9a7c7
to
ecc654a
Compare
Thanks for taking a look. I've added v3 to the todo |
* AutoSkip in update * Address review comments * Add v3 to TODO * Address review comments * Remove unrelated code cleanup
No description provided.