Correctly handle stacked groups when not adjacent #4937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- issue chartjs#4897: Non adjacent stacked group is not rendered correctly
benmccann
approved these changes
Nov 11, 2017
etimberg
approved these changes
Nov 11, 2017
simonbrunel
reviewed
Nov 14, 2017
src/controllers/controller.bar.js
Outdated
| }, | ||
|
|
||
| /** | ||
| * Returns the stack index for the given dataset based on groups and bar visibility. | ||
| * @param {Number=} [datasetIndex] - The dataset index |
There was a problem hiding this comment.
[nit] what the purpose of = in {Number=}?
There was a problem hiding this comment.
Indicates that it's optional: http://usejsdoc.org/tags-type.html
Though I don't think we need both the equals and square brackets. That would seem redundant to me. I would think we should just use one or the other. I was more familiar with the = syntax
There was a problem hiding this comment.
Didn't take time to look around, thinking it was a typo, thanks @benmccann! I agree, it's redundant, and I think we already adopted the other form {Number} [datasetIndex] - ..., so I would continue with that one.
simonbrunel
changed the title
|
Thanks @jcopperfield |
yofreke
pushed a commit
to yofreke/Chart.js
that referenced
this pull request
Dec 30, 2017
Only the dataset index was used for indexing the stack
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Only the dataset index was used for indexing the stack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4897 (stacked group is not rendered correctly when stack group is not adjacent).
Split from PR #4911
Problem
Only the dataset index was used for indexing the stack.