Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fixes compilation error when option --isolatedModules is set #11095

Merged
merged 2 commits into from
Jan 28, 2023
Merged

🐛 fixes compilation error when option --isolatedModules is set #11095

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df1c0ef
🐛 fixes compilation error when option --isolatedModules is set
jljouannic Jan 27, 2023
150897a
♻️ preserve UpdateModeEnum to prevent breaking change
jljouannic Jan 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions src/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,17 +566,7 @@ export declare type ChartItem =
| { canvas: HTMLCanvasElement }
| ArrayLike<CanvasRenderingContext2D | HTMLCanvasElement>;

export declare const enum UpdateModeEnum {
resize = 'resize',
reset = 'reset',
none = 'none',
hide = 'hide',
show = 'show',
default = 'default',
active = 'active'
}

export type UpdateMode = keyof typeof UpdateModeEnum;
export type UpdateMode = 'resize' | 'reset' | 'none' | 'hide' | 'show' | 'default' | 'active';

export declare class DatasetController<
TType extends ChartType = ChartType,
Expand Down