Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making ticks objects #5019

Closed
benmccann opened this issue Dec 2, 2017 · 6 comments · Fixed by #6645
Closed

Consider making ticks objects #5019

benmccann opened this issue Dec 2, 2017 · 6 comments · Fixed by #6645

Comments

@benmccann
Copy link
Contributor

benmccann commented Dec 2, 2017

Making ticks objects will allow us to create properties on those ticks. E.g. could have major/minor ticks, support different styles for each tick, etc.

Related tickets: #4502 (comment) and #4573

@benmccann benmccann added this to the Version 3.0 milestone Dec 2, 2017
@simonbrunel
Copy link
Member

That's brief! What does that mean and why isn't possible in v2? can you describe this feature/bug more precisely? You re-opened #1692, why both tickets?

@benmccann
Copy link
Contributor Author

#1692 is separate and refers to the chart config

This ticket is suggesting making all scales use an object inside of ticks

@simonbrunel
Copy link
Member

Isn't it already the case ?

@benmccann
Copy link
Contributor Author

Do all scales? I thought it was just the time scale, but my memory could be wrong

We could rename this issue to track removing the compatibility layer if it's already implemented in all scales

@simonbrunel
Copy link
Member

All scale yes and there is a compatibility layer indeed.

@etimberg
Copy link
Member

etimberg commented Dec 3, 2017

Let's consider adding a checklist to this. I think it would need: "Implement in Radial scale", "Remove compatibility layer", "Add documentation on properties in tick object"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants