[UPDATE] Updated project to 0.19.1 #38
Conversation
NullDivision
commented
Dec 10, 2015
NullDivision
commented
- added some ignores to flow from node_modules
- updated Babel to version 6
- fixed kill function so it kills even if no args are present
- added message when the next message is part of current file
- separated lint functions
- fixed test failing on new version
- latest stable versions installed for all packages
- added some ignores to flow from node_modules - updated Babel to version 6 - fixed kill function so it kills even if no args are present - added message when the next message is part of current file - separated lint functions - fixed test failing on new version - latest stable versions installed for all packages
| var flowToJshint = require('flow-to-jshint'); | ||
| var stylishReporter = require(require('jshint-stylish')).reporter; | ||
| var stylishReporter = require('jshint-stylish').reporter; |
There was a problem hiding this comment.
'require' is not defined.
|
I found an issue with default options not being translated so please hold off on this request. Sorry. |
|
Everything should be working correctly. Issues resolved:
|
|
Hi, Thanks a lot for doing this, much appreciated! It all looks good to me except from the multiline errors. Output from original code: My flow-to-jshint splits new lines and splices them into a single line separated by '-' as I feel it looks much neater. Cheers, |
|
I did not know that :) I'll have to take a look at the docs for |
|
So, the issue is that the new implementation (because I'm not sure of the old one) is that errors are no longer in a single message but in multiple messages per error. As this is no longer the case would it be possible to merge with the new implementation and then change it to single line if that's what you want? |
| return error.message.length > 0; | ||
| let lastFile = ''; | ||
| let isCurrentFile = error.message[0].path === _path; | ||
| let generalError = (/(Fatal)/.test(error.message[0].descr)); |
There was a problem hiding this comment.
'let' is available in ES6 (use esnext option) or Mozilla JS extensions (use moz).
|
While going through documentation and various tests here's what I discovered:
As such I removed the whole block that tests next and previous messages because all 3 messages together make up the context as a whole, otherwise you'd end up with an error like |
- messages restructured in flow - update to Flow 0.20.1 - added stage 2 for babel
|
Oh, and I also incremented to version 0.49.0 and updated Flow to 0.20.1. |
[UPDATE] Updated project to 0.19.1
|
Hi, Thanks a lot for the PR, it should now be published. My internet dropped out while publishing so I am not sure if it worked, tried to re-publish but can't overwrite the version number. Let me know if you have any issues with Cheers, |
