Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting abort = true has no effect #25

Closed
r-peck opened this issue Mar 17, 2015 · 4 comments
Closed

Setting abort = true has no effect #25

r-peck opened this issue Mar 17, 2015 · 4 comments

Comments

@r-peck
Copy link

r-peck commented Mar 17, 2015

The check for the abort flag is being done against args instead of opts. Since args.abort is always falsy, it never aborts.

@r-peck
Copy link
Author

r-peck commented Mar 17, 2015

Also, would be nice to emit events on error regardless of if it aborts or not, and/or include an indication of pass/fail with the 'end' event.

@charliedowler
Copy link
Collaborator

Cheers, will look into it asap!

charliedowler added a commit that referenced this issue Mar 22, 2015
charliedowler added a commit that referenced this issue Mar 22, 2015
@charliedowler
Copy link
Collaborator

Hi, this is fixed in the latest release.

As the file path and errors are already logged in the console, what else would need to be logged?

Cheers!

@r-peck
Copy link
Author

r-peck commented Apr 14, 2015

It wouldn't be additional logging, it would be emitting events to which the gulp task using this could react. Currently, if abort is false, the task has no clean way of determining if errors occurred or not. I was suggesting either an event that is emitted as the errors are encountered or an indication of if errors occurred being sent with the 'end' event.

This would enable a full run (errors across all files being processed) while still allowing the task to abort if necessary (or even more complex behavior, such as ensuring the number of errors encountered does not increase over the last known number if working with code known to have existing issues).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants