-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting abort = true has no effect #25
Comments
Also, would be nice to emit events on error regardless of if it aborts or not, and/or include an indication of pass/fail with the 'end' event. |
Cheers, will look into it asap! |
Hi, this is fixed in the latest release. As the file path and errors are already logged in the console, what else would need to be logged? Cheers! |
It wouldn't be additional logging, it would be emitting events to which the gulp task using this could react. Currently, if This would enable a full run (errors across all files being processed) while still allowing the task to abort if necessary (or even more complex behavior, such as ensuring the number of errors encountered does not increase over the last known number if working with code known to have existing issues). |
The check for the
abort
flag is being done againstargs
instead ofopts
. Sinceargs.abort
is always falsy, it never aborts.The text was updated successfully, but these errors were encountered: