Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some minor fixes #29

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Some minor fixes #29

wants to merge 5 commits into from

Conversation

swapneils
Copy link

Fix #27 by ensuring the point is placed at the relevant bookmark entry when org-mode functions are called, using save-window-excursion and save-mark-and-excursion to keep this from affecting user experience.

Major note: As with the original code, the buffer needs to be saved manually.

Minor note: Sometimes the wget process doesn't finish by the time org-mode notices the ARCHIVED_AT link, so it initially appears dead. Waiting until the process finishes and [saving and] refreshing the buffer fixes this.

Minor note: This doesn't suppress the wget buffer, it just keeps it from appearing on-screen.

charlesroelli
charlesroelli reviewed Mar 4, 2023
View reviewed changes
org-board.el Outdated Show resolved Hide resolved
@charlesroelli
Copy link
Owner

Thanks a lot for taking this initiative! Please see comments above.

@swapneils
Copy link
Author

Some people might be running this on old emacs versions without cl-lib required, so refactored to use dolist (escaping with a custom error when a valid browser is found) instead of (require 'cl-lib).

As for the repeating org-id-goto, sometimes the point would move to the process buffer during the property-assignment. Not sure why, but to be safe I've moved org-display-outline-path to the let bindings.

@swapneils swapneils changed the title Fix for #27 (https://github.com/charlesroelli/org-board/issues/27) Some minor fixes Mar 5, 2023
@charlesroelli
Copy link
Owner

Thanks for the fixes! Will merge this after some more local testing.

@charlesroelli
Copy link
Owner

Hm, I got an error org-id-goto: Cannot find entry with ID "B7AC258E-FE9D-402D-95A8-982A0B534D38" when running org-board-archive from this branch in a test file with contents:

** TODO Linkers (20-part series)                                                
:PROPERTIES:                                                                    
:URL: http://a3f.at/lists/linkers                                               
:WGET_OPTIONS: --recursive -l 1 --span-hosts                                    
:END:

in Emacs 28.2. Then I ran org-board-archive again and it worked! I'm not sure if the error is related specifically to this branch or if this problem already exists in the org-board master branch when running on Emacs 28.2. I need to add some tests...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesroelli charlesroelli charlesroelli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty ARCHIVED_AT property after running org-borad-new
2 participants
@swapneils @charlesroelli