Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Android the Refresh message is not being disposed #13

Open
josesimas opened this issue Apr 24, 2019 · 0 comments
Open

On Android the Refresh message is not being disposed #13

josesimas opened this issue Apr 24, 2019 · 0 comments

Comments

@josesimas
Copy link

Hello,

On the MapViewRenderer for iOS the Dispose method is overriden and the Refresh message is unsubscribed. This is missing on the Android MapViewRenderer. In my tests this message was not cleared in OnElementChanged and I had to add:

protected override void Dispose(bool disposing)
{
    MessagingCenter.Unsubscribe<MapView>(this, "Refresh");
    base.Dispose(disposing);
}

Maybe this should not be an issue but since you are moving on to a new implementation I thought I would leave this here in case someone finds it useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant