Skip to content
This repository has been archived by the owner on Jul 5, 2023. It is now read-only.

Feature Request: --verify option for CI #429

Open
bmulholland opened this issue Jun 24, 2021 · 1 comment
Open

Feature Request: --verify option for CI #429

bmulholland opened this issue Jun 24, 2021 · 1 comment

Comments

@bmulholland
Copy link

bmulholland commented Jun 24, 2021

Problem: It's very easy to make a change and forget to refresh the generated objects, resulting in out-of-sync RBIs

It's possible to run the generation as a git hook, but this can slow things down, and there's no way to guarantee that the hook runs anyway.

I'd like to add a check to my CI that guarantees that the models are up to date so that CI can fail changes that don't do this properly. tapioca just added a --verify option - is that possible for this project, too?

@smt116
Copy link

smt116 commented Dec 21, 2021

👍 for this. We have a similar CI check as a shell script:

#!/bin/sh

set -e

cp -R sorbet sorbet.checked

# ...

bundle exec rails rails_rbi:helpers
bundle exec rails rails_rbi:jobs
bundle exec rails rails_rbi:mailers
bundle exec rails rails_rbi:models
bundle exec rails rails_rbi:routes

diff --brief --recursive sorbet sorbet.checked

# ...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants