From fa43a1258cc6da93f8f1c591d135a8d5a84ec440 Mon Sep 17 00:00:00 2001
From: Hayden Spitzley <hspitzley@chanzuckerberg.com>
Date: Fri, 23 Feb 2024 08:13:08 -0700
Subject: [PATCH] review dog hasnt been running bc the trigger was push and it
 only runs on pr

---
 .github/workflows/ci.yml         | 44 ++++++++------------------------
 .github/workflows/mod-update.yml |  2 +-
 2 files changed, 11 insertions(+), 35 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 6e3a7df8..74c2f269 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -1,4 +1,5 @@
-on: push
+on:
+  - pull_request
 
 name: CI
 
@@ -17,7 +18,7 @@ jobs:
         id: changedGoPackages
         uses: ./.github/actions/find-changed-packages
 
-  run:
+  run-ci:
     runs-on: [ARM64, self-hosted, Linux]
     needs: find-changed-packages
     if: ${{ needs.find-changed-packages.outputs.changedPackages != '[]' }}
@@ -29,38 +30,6 @@ jobs:
           - lint-ci
 
     steps:
-      # - name: Generate token
-      #   id: generate_token
-      #   uses: chanzuckerberg/github-app-token@v1.1.4
-      #   with:
-      #     app_id: ${{ secrets.CZI_GITHUB_HELPER_APP_ID }}
-      #     private_key: ${{ secrets.CZI_GITHUB_HELPER_PK }}
-      # - uses: actions/checkout@v4
-      #   with:
-      #     token: ${{ steps.generate_token.outputs.token }}
-      #     ref: ${{ github.event.pull_request.head.ref }}
-      # - uses: actions/setup-go@v5
-      #   with:
-      #     go-version-file: ${{ matrix.gopkg }}/go.mod
-      #     cache: true
-      # - name: Run tests
-      #   run: make test-ci
-      #   working-directory: ${{ matrix.gopkg }}
-      # - name: golangci-lint
-      #   uses: golangci/golangci-lint-action@v3
-      #   with:
-      #     version: v1.54.2
-      #     github-token: ${{ secrets.GITHUB_TOKEN }}
-      #     args: --timeout 10m0s --out-format=tab --fix --config=../.golangci.yml
-      #     working-directory: ${{ matrix.gopkg }}
-      #     skip-pkg-cache: true
-      # - uses: EndBug/add-and-commit@v9
-      #   id: commit_linter_changes
-      #   with:
-      #     add: -A
-      #     message: ci - linter fixes for ${{ matrix.gopkg }} package
-
-
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
@@ -74,3 +43,10 @@ jobs:
           REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: make ${{ matrix.target }}
         working-directory: ${{ matrix.gopkg }}
+
+  # this job exists to give us something to make a required check on that will ensure all CI runs are complete
+  run-ci-complete:
+    runs-on: [ARM64, self-hosted, Linux]
+    needs: run-ci
+    steps:
+      - run: echo "CI runs complete"
diff --git a/.github/workflows/mod-update.yml b/.github/workflows/mod-update.yml
index 426317cc..a02107bc 100644
--- a/.github/workflows/mod-update.yml
+++ b/.github/workflows/mod-update.yml
@@ -49,7 +49,7 @@ jobs:
         id: commit_go_mod
         with:
           add: -A
-          message: ci - update ${{ matrix.gopkg }} go.mod
+          message: ci - update ${{ matrix.gopkg }}/go.mod
 
   # this job exists to give us something to make a required check on that will ensure all go.mod updates are complete
   go-mod-updates-complete: