-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow fogg to authenticate with GH OAuth token #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edulop91
reviewed
Jun 13, 2022
edulop91
reviewed
Jun 13, 2022
edulop91
reviewed
Jun 13, 2022
edulop91
reviewed
Jun 13, 2022
edulop91
reviewed
Jun 13, 2022
alldoami
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a feature to fogg that allows the user to provide a Github OAuth token when doing module source downloading instead of SSH keys. This is handy for bot users and OAuth automation that use Fogg in the backend and don't have SSH keys. This should allow someone to do the following:
Where the
FOGG_GITHUBTOKEN
is a personal access token or a token received through an OAuth flow.Test Plan
References
(Optional) Additional links to provide more context.