Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify OntologyParser to take schema version and Ontology name #94

Closed
Bento007 opened this issue Mar 6, 2024 · 2 comments
Closed

Comments

@Bento007
Copy link
Collaborator

Bento007 commented Mar 6, 2024

thoughts on refactoring this class to also take an ontology_name, so we can load the ontology file to read from in init and not have to request that as an input in every method? i.e. they can initialize `cl_parser = OntologyParser("5.0.0", "CL")

We can also take care of this in a follow-up PR, if you prefer

Originally posted by @nayib-jose-gloria in #93 (comment)

@Bento007
Copy link
Collaborator Author

@nayib-jose-gloria I don't think this add much value give the current implementation. We don't pass ontology in any of the OntologyParser functions so it's completely hidden from users.

@Bento007
Copy link
Collaborator Author

Closing because not needed at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant