chore: update ontology decendant mappings #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
=======================================
Coverage 84.62% 84.62%
=======================================
Files 19 19
Lines 969 969
Branches 186 186
=======================================
Hits 820 820
Misses 139 139
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Bento007
requested changes
Apr 2, 2024
| @@ -1,3 +1,4 @@ | |||
| cellxgene-ontology-guide | |||
There was a problem hiding this comment.
The last line of this file should install cellxgene-ontology-guide from the current branch. If that isn't what we want then remove it.
There was a problem hiding this comment.
rename to generate_desendant_mapping.yml
| on: | ||
| push: | ||
| paths: | ||
| - "**/ontology-assets/**.json" |
There was a problem hiding this comment.
We should change this to trigger on "- **/ontology-assets/**decendants.json" and remove trigger on - "**/ontology-assets/**.gz"
There was a problem hiding this comment.
we might want it to trigger if other assets get updated as well, though--in case a frontend ever needs to fetch a latest curated list, for instance. Or do you think we should just wait until we get to that
Bento007
approved these changes
Apr 2, 2024
This was referenced Apr 2, 2024
Closed
Closed
Closed
Merged
Bento007
pushed a commit
that referenced
this pull request
Apr 9, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>python-api: 0.5.0</summary> ## [0.5.0](python-api-v0.4.0...python-api-v0.5.0) (2024-04-09) ### Features * add term label to OntologyNode ([#182](#182)) ([326185c](326185c)) * fetch ontology term descriptions, if available ([#181](#181)) ([0120377](0120377)) ### Misc * add doctesting to API ([#176](#176)) ([c0aec23](c0aec23)) * deprecate older version of cellxgene schema ([#172](#172)) ([186e762](186e762)) * move pytest configs to pyproject.toml ([#175](#175)) ([a90341b](a90341b)) </details> <details><summary>ontology-assets: 0.3.0</summary> ## [0.3.0](ontology-assets-v0.2.0...ontology-assets-v0.3.0) (2024-04-09) ### Features * fetch ontology term descriptions, if available ([#181](#181)) ([0120377](0120377)) ### Misc * deprecate older version of cellxgene schema ([#172](#172)) ([186e762](186e762)) * update ontology decendant mappings ([#162](#162)) ([12def74](12def74)) * update ontology descendant mappings ([#167](#167)) ([5d3d097](5d3d097)) * update ontology descendant mappings ([#180](#180)) ([65ca10f](65ca10f)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Bento007
pushed a commit
that referenced
this pull request
Apr 9, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>assets: 0.4.0</summary> ## [0.4.0](assets-v0.3.0...assets-v0.4.0) (2024-04-09) ### Features * add function to fetch curated ontology term lists ([#141](#141)) ([5c7db62](5c7db62)) * fetch ontology term descriptions, if available ([#181](#181)) ([0120377](0120377)) * load GH Release Assets for schema version in memory ([#72](#72)) ([58bad0a](58bad0a)) * refactor ancestry mapping to include distance from descendant node + implement functions to support curated list term mapping ([#96](#96)) ([7fc3562](7fc3562)) * refer to ontology source filenames in ontology_info and return that in get_ontology_download_url ([#106](#106)) ([ff9d826](ff9d826)) * **release:** generate descendant mapping for tissues and cells ([#100](#100)) ([841fddf](841fddf)) * remove all-ontology.json.gz ([83fefd6](83fefd6)) * split all_ontology into individual files. ([#93](#93)) ([ead59e5](ead59e5)) * upload assets on release ([#56](#56)) ([84a1c5d](84a1c5d)) ### Misc * deprecate older version of cellxgene schema ([#172](#172)) ([186e762](186e762)) * move curated lists to ontology-assets ([#48](#48)) ([77916df](77916df)) * moving the generated artifacts ([c03c8e3](c03c8e3)) * release main ([#130](#130)) ([0b37dc8](0b37dc8)) * release main ([#146](#146)) ([4ca76f0](4ca76f0)) * release main ([#185](#185)) ([9b2fe53](9b2fe53)) * release main ([#74](#74)) ([e748fe9](e748fe9)) * release tsmith/release-assets ([63b782d](63b782d)) * release tsmith/release-assets ([#57](#57)) ([6a6b02a](6a6b02a)) * update ontology decendant mappings ([#117](#117)) ([48451af](48451af)) * update ontology decendant mappings ([#142](#142)) ([fb23618](fb23618)) * update ontology decendant mappings ([#162](#162)) ([12def74](12def74)) * update ontology descendant mappings ([#167](#167)) ([5d3d097](5d3d097)) * update ontology descendant mappings ([#180](#180)) ([65ca10f](65ca10f)) ### BugFixes * lint errors ([f5e4583](f5e4583)) * Schema format and validation fixes. ([#113](#113)) ([0465ee7](0465ee7)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action
Additional Manual Changes:
#158