Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button component should be disabled when it is loading state #2299

Open
yangwooseong opened this issue Jun 20, 2024 · 2 comments
Open

Button component should be disabled when it is loading state #2299

yangwooseong opened this issue Jun 20, 2024 · 2 comments
Labels
enhancement Issues or PR related to making existing features better good first issue Issue that good for newcomers

Comments

@yangwooseong
Copy link
Collaborator

yangwooseong commented Jun 20, 2024

Description

버튼이 로딩 상태일 때 컴포넌트 내부적으로 disabled된 상태면 좋겠습니다 (suggested by @igy95 )

Reasons for suggestion

현재 disabled 처리를 해주고 있지 않아서, 어플리케이션에서 버튼이 로딩 상태일 때 disabled인 곳과 아닌 곳이 혼재되어 있습니다.

Proposed solution

  1. V2의 AlphaButton 까지 수정되면 좋겠습니다.
  2. (optional) 만약 어플리케이션에서 disabled와 loading 에 같은 값을 주고 있는 경우가 많다면, disabled 속성을 제거하는 codemod를 만들어봐도 좋을 것 같습니다.

References

스레드(internal)

@yangwooseong yangwooseong added the status:need triage Issue or PR that need triage attention label Jun 20, 2024
Copy link

channeltalk bot commented Jun 20, 2024

@yangwooseong yangwooseong added enhancement Issues or PR related to making existing features better good first issue Issue that good for newcomers and removed status:need triage Issue or PR that need triage attention labels Jun 20, 2024
@yangwooseong
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues or PR related to making existing features better good first issue Issue that good for newcomers
Projects
No open projects
Status: 📌 Backlog
Development

No branches or pull requests

1 participant