Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temperature is missing #1

Open
thewh1teagle opened this issue Dec 27, 2024 · 1 comment
Open

Temperature is missing #1

thewh1teagle opened this issue Dec 27, 2024 · 1 comment

Comments

@thewh1teagle
Copy link

First, I want to say the work on this repo is impressive. great use of clever techniques!

It would be really helpful to have a separate crate for the LibreHardwareMonitor wrapper, making it accessible for other Rust projects.

I downloaded the app and ran it, but noticed that the temperature data is missing:

Interestingly, the temperature readings are visible in LibreHardwareMonitor itself.

I’m also curious about the wrapper implementation. I see it retrieves the entire report each time. does this result in significantly higher resource usage compared to fetching individual data points, like just the temperature?

Thanks!

@chanderlud
Copy link
Owner

hi, appreciate the kind words.

the missing temperature data is probably related to the less than stellar logic that loads LHM sensors into the System structure. i'll blame this on the inconsistent sensor naming scheme for AMD CPUs.

for your efficiency question, i think that updating specific sensors may be more efficient in the c# code. im not actually sure that LHM supports updating a single sensor, seems like it would. less sensors in each update that goes through the wrapper would probably be more efficient, not 100% sure.

and for the idea of making a crate from this wrapper, it could definitely be done, but i don't feel this version is mature enough to be made available in that way. for example, if your system has a particularly large number of LHM sensors it will panic the wrapper and crash the application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants