xplat: Improve ICU fallback conditions #3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure ICU path exists and support relative paths. Keep build from no-icu fallback in case custom path is given
kfarnung
approved these changes
Jun 9, 2017
kunalspathak
approved these changes
Jun 9, 2017
|
@kfarnung @kunalspathak Thanks for the review |
chakrabot
pushed a commit
that referenced
this pull request
Jun 13, 2017
Merge pull request #3135 from obastemur:dont_fall node-chakracore was silently falling back to `no-icu`. Couple of changes to be more proactive when a custom ICU path is given. Similarly, do not fallback to `no-icu` when custom ICU path is given.
chakrabot
pushed a commit
that referenced
this pull request
Jun 13, 2017
…ions Merge pull request #3135 from obastemur:dont_fall node-chakracore was silently falling back to `no-icu`. Couple of changes to be more proactive when a custom ICU path is given. Similarly, do not fallback to `no-icu` when custom ICU path is given.
chakrabot
pushed a commit
that referenced
this pull request
Jun 13, 2017
…llback conditions Merge pull request #3135 from obastemur:dont_fall node-chakracore was silently falling back to `no-icu`. Couple of changes to be more proactive when a custom ICU path is given. Similarly, do not fallback to `no-icu` when custom ICU path is given.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-chakracore was silently falling back to
no-icu. Couple of changes to be more proactive when a custom ICU path is given. Similarly, do not fallback tono-icuwhen custom ICU path is given.