Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RegExp] /[\s-a-c]/ is parsed incorrectly #258

Closed
goyakin opened this issue Feb 3, 2016 · 0 comments
Closed

[RegExp] /[\s-a-c]/ is parsed incorrectly #258

goyakin opened this issue Feb 3, 2016 · 0 comments
Assignees
@kfukuda2
Labels
Bug ES Spec Changed help wanted Severity: 2
Milestone
1.10

Comments

@goyakin
Copy link

goyakin commented Feb 3, 2016

Currently, Chakra parses /[\s-a-c]/ as:

  • The character class \s
  • The character -
  • The range a-c

However, other engines parse it as:

  • The range \s-a, which is treated as the union of class \s, and the characters - and a
  • The character -
  • The character c

As a result, Chakra matches the character b with this pattern whereas others don't.

Annex B of the spec has been changed to the rules used by other engines, so Chakra should be updated to match the spec.
@goyakin goyakin added the Bug label Feb 3, 2016
@curtisman curtisman added Bug and removed Bug labels Feb 10, 2016
@abchatra abchatra added this to the 1.2 milestone Mar 10, 2016
@abchatra abchatra removed this from the 1.2 milestone Mar 24, 2016
@goyakin goyakin removed their assignment Apr 30, 2016
@dilijev dilijev added this to the Backlog milestone Aug 25, 2016
@dilijev dilijev self-assigned this Nov 15, 2016
@dilijev dilijev changed the title /[\s-a-c]/ is parsed incorrectly [RegExp] /[\s-a-c]/ is parsed incorrectly Nov 15, 2016
@dilijev dilijev modified the milestones: Backlog, 1.4.1 candidates Dec 20, 2016
@dilijev dilijev modified the milestones: Backlog, 1.4.1 candidates Jan 14, 2017
@dilijev dilijev removed their assignment Sep 6, 2017
@dilijev dilijev modified the milestones: Backlog, 1.10 Jun 6, 2018
@dilijev dilijev self-assigned this Jun 6, 2018
@curtisman curtisman assigned dilijev and kfukuda2 and unassigned dilijev Jun 26, 2018
@kfukuda2 kfukuda2 mentioned this issue Jul 3, 2018
Merged
kfukuda2 pushed a commit to kfukuda2/ChakraCore that referenced this issue Jul 3, 2018
Fixing RegExp parsing for character classes interacting with ranges.
47797ff 
Fixes chakra-core#258
kfukuda2 pushed a commit to kfukuda2/ChakraCore that referenced this issue Jul 6, 2018
Fixing RegExp parsing for character classes interacting with ranges.
7e5f990 
Fixes chakra-core#258
chakrabot pushed a commit that referenced this issue Jul 10, 2018
[MERGE #5418 @kfukuda2] Fixing RegExp parsing for character classes i…
288d7fe 
…nteracting with ranges.

Merge pull request #5418 from kfukuda2:RegExpCharacterClassRangeFix

Fixes #258
chakrabot pushed a commit that referenced this issue Jul 10, 2018
[1.10>master] [MERGE #5418 @kfukuda2] Fixing RegExp parsing for chara…
2aeb63f 
…cter classes interacting with ranges.

Merge pull request #5418 from kfukuda2:RegExpCharacterClassRangeFix

Fixes #258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kfukuda2 kfukuda2

Labels
Bug ES Spec Changed help wanted Severity: 2
Projects
None yet
Milestone
1.10
Development

No branches or pull requests
6 participants
@bterlson @dilijev @abchatra @kfukuda2 @curtisman @goyakin