Skip to content

Commit

Permalink
[MERGE #1279 @jianchun] nativetests: fix static crt build
Browse files Browse the repository at this point in the history
Merge pull request #1279 from jianchun:nativetestsstatic

The ChakraCore solution can be built with static CRT
(`msbuild /p:Runtime=static_library ...`). NativeTests.vcxproj should not
specify its own `RuntimeLibrary` property. Should use imported props.
  • Loading branch information
Jianchun Xu committed Jul 15, 2016
2 parents e2b0ccd + 63c9211 commit e9e1ce1
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion bin/NativeTests/NativeTests.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
$(ChakraCoreRootDirectory)bin\External;
%(AdditionalIncludeDirectories)
</AdditionalIncludeDirectories>
<RuntimeLibrary Condition="'$(Configuration)'=='Debug'">MultiThreadedDebugDLL</RuntimeLibrary>
<MultiProcessorCompilation>true</MultiProcessorCompilation>
<SmallerTypeCheck>false</SmallerTypeCheck>
<MinimalRebuild>false</MinimalRebuild>
Expand Down

0 comments on commit e9e1ce1

Please sign in to comment.