Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff shows unchanged files as "changed" #689

Open
tstromberg opened this issue Dec 10, 2024 · 1 comment · May be fixed by #726
Open

diff shows unchanged files as "changed" #689

tstromberg opened this issue Dec 10, 2024 · 1 comment · May be fixed by #726

Comments

@tstromberg
Copy link
Collaborator

cd malcontent-samples/python/2024.ultralytics
mal diff v8.3.40 v8.3.41

results in many Changed file entries with no changes noted in the UI:

├─ 🟡 Changed: v8.3.41/engine/predictor.py
│     ≡ command & control [MEDIUM]
│       🟡 tool_transfer/os — references multiple operating systems: Linux, https://, macOS
│     ≡ discovery [MEDIUM]
│       🟡 system/platform — system platform identification: platform.system()
│     ≡ execution [LOW]
│       🔵 imports/python — imports python modules:
│          from pathlib import Path, from ultralytics.cfg import get, from ultralytics.data import load, from ultralytics.data.augment import LetterBox, from ultraly…
│     ≡ filesystem [LOW]
│       🔵 directory/create — creates directories: mkdir
│     ≡ networking [LOW]
│       🔵 url/embedded — contains embedded HTTPS URLs: https://docs.ultralytics.com/modes/predict/, https://youtu.be/LNwODJXcvt4
│     ≡ operating-system [LOW]
│       🔵 fd/multiplex — monitor multiple file descriptors: select
│
@egibs
Copy link
Member

egibs commented Dec 18, 2024

This is just a generic catch-all:

} else {
title = fmt.Sprintf("Changed: %s", modified.Value.Path)
}

I think we can move that into renderFileSummary and set it based on specific conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants