Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving ./cmd/apko/main.go to ./main.go #31

Closed
imjasonh opened this issue Mar 1, 2022 · 1 comment · Fixed by #32
Closed

Consider moving ./cmd/apko/main.go to ./main.go #31

imjasonh opened this issue Mar 1, 2022 · 1 comment · Fixed by #32

Comments

@imjasonh
Copy link
Member

imjasonh commented Mar 1, 2022

ko used to be in ./cmd/ko, but @n3wscott correctly pointed out that makes the go install instructions needlessly long and stutttery, so we moved it to ./main.go and made ./cmd/ko/main.go log a warning then call the usual cobra root entrypoint.

See ko-build/ko#257 for the whole saga.

If you think apko will follow a similar path, it might be worth moving it up now, while there are few enough users.

If this sgty I can send a PR.

@kaniini
Copy link
Contributor

kaniini commented Mar 1, 2022

Go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants