fix(ssz): backwards compatibility on SignedBidSubmission
#27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces another variant to the
SignedBidSubmission
enum calledDenebWithProofs
.It is needed in order to have a separate SSZ serialization fork the a signed bid submission containing inclusion proofs (see docs) and keeping backwards compatibility with the regular
submit_block
endpoint of the Relay API.Note: this type is deserialized using
#[ssz(transparent)]
, which analogous to#[serde(untagged)]
but for SSZ. This implies a small overhead because the deserialization might not succeed at the first attempt with the first variant. The overhead can be removed or greatly reduced but it requires more changes and refactors. In accordance with the Gattaca team for now we'll go for this approach.