chore(bolt-sidecar): extract compute_diffs() #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merklefruit
reviewed
Nov 28, 2024
thedevbirb
reviewed
Nov 28, 2024
bolt-sidecar/src/state/execution.rs
Outdated
Comment on lines
634
to
656
| let mut block_templates = HashMap::new(); | ||
| let sender = Address::random(); | ||
|
|
||
| let mut diffs = HashMap::new(); | ||
| diffs.insert(sender.clone(), (1, U256::from(2))); | ||
|
|
||
| let mut state_diff = StateDiff::default(); | ||
| state_diff.diffs = diffs.clone(); | ||
|
|
||
| let block_template = BlockTemplate { state_diff, signed_constraints_list: vec![] }; | ||
|
|
||
| block_templates.insert(10, block_template); | ||
|
|
||
| let (nonce_diff, balance_diff, highest_slot) = compute_diffs(&block_templates, &sender); | ||
|
|
||
| assert_eq!(nonce_diff, 1); | ||
| assert_eq!(balance_diff, U256::from(2)); | ||
| assert_eq!(highest_slot, 10); |
There was a problem hiding this comment.
Can you add comments for the steps, so that I can read the test without simulating the code in my head?
There was a problem hiding this comment.
Can't run a RISCV VM in your head in 2024? ngmi
merklefruit
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validate_request()is very long and hard to follow, so breaking it up and adding tests