feat(registry): cheaper on-chain batch opt-in (48k gas) #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merklefruit
commented
Oct 28, 2024
merklefruit
force-pushed
the
nico/feat/cheaper-unsafe-optin
branch
from
d8fca6e
to
bec46ba
Compare
merklefruit
added
C: smart-contracts
merklefruit
changed the title
merklefruit
changed the title
thedevbirb
reviewed
Oct 29, 2024
There was a problem hiding this comment.
Commenting it here but applies a bit everywhere: wdyt of having a type CompressedHash (or similar name) alias to bytes20? I found it really counter-intuitive to read bytes20 pubkeyHash etc
thedevbirb
approved these changes
Oct 30, 2024
| error OperatorAlreadyRegistered(); | ||
| error OperatorNotRegistered(); | ||
| error UnauthorizedMiddleware(); | ||
| error InactiveOperator(); |
There was a problem hiding this comment.
By grepping over the codebase I've seen InactiveOperator is unused.
There was a problem hiding this comment.
Damn missed this - added a TODO comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces a slightly more optimized version of
BoltValidatorsthat uses an internal libraryValidatorsLib.The main gain in efficiency is due to the new
_Validatorstruct that tightly packs necessary info in a single slot, containing pointers to other mappings, offloading the majority of storage costs when batch registering.The optimizations performed are geared toward storage costs rather than runtime costs.
In particular the loops, variables, event emission, and other runtime checks haven't been optimized/removed.
Gas usage
We benchmarked
BoltValidatorsV2(new implementation) vsBoltValidatorsV1(old implementation).The image below shows the efficiency curve of batch registration costs:
Meta