feat(sidecar): load delegations on startup and send them upon registration #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merklefruit
commented
Oct 15, 2024
bolt-sidecar/src/driver.rs
Outdated
Comment on lines
276
to
288
| let delegatees = self.constraints_client.find_delegatees(&validator_pubkey); | ||
| let available_pubkeys = self.constraint_signer.available_pubkeys(); | ||
|
|
||
| // Pick a pubkey to sign constraints with. | ||
| // | ||
| // Rationale: | ||
| // - If there are no delegatee keys, try to use the validator key directly if available. | ||
| // - If there are delegatee keys, try to use the first one that is available in the list. | ||
| let Some(pubkey) = pick_public_key(validator_pubkey, available_pubkeys, delegatees) else { | ||
| error!(%target_slot, "No available public key to sign constraints with"); | ||
| let _ = response.send(Err(CommitmentError::Internal)); | ||
| return; | ||
| }; |
There was a problem hiding this comment.
this is quite inefficient but the logic should check out. Let me know your thoughts!
thedevbirb
reviewed
Oct 15, 2024
mempirate
reviewed
Oct 15, 2024
thedevbirb
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Optsfrom a TOML file, loaded optionally if theBOLT_SIDECAR_CONFIG_PATHis definedsigning.delegationsfile path option that will parse SignedDelegations from JSON if presentdelegate()duringregister_validators()so they are done together to signal delegations regularly. We should maybe think of a better strategy as this could be inefficient if done with many delegations (e.g. 10k+ validators).delegationandtransactiontypes to their own file).Note: this PR changes the constraints API body type for
delegate()andrevoke()to take Vec instead of T.Following PRs in bolt-boost and mev-boost should reflect this change.
Meta