Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Human Readable Protobuf Msg for Custom Txs #248

Open
paplco opened this issue Jan 12, 2022 · 3 comments
Open

Show Human Readable Protobuf Msg for Custom Txs #248

paplco opened this issue Jan 12, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@paplco
Copy link

paplco commented Jan 12, 2022

Is your feature request related to a problem? Please describe.
When working with custom messages such as those found in the Regen ecocredit module, users of keplr wallet will see the protobuf binary string for message value and not the human readable message.

I am using custom message registry method as described in: https://github.com/cosmos/cosmjs/blob/main/packages/stargate/CUSTOM_PROTOBUF_CODECS.md

This issue was noted as a side effect of protobuf singing.
Quote from commit: "Also, because protobuf sign doc is binary formatted, msgs not natively supported by Keplr may not be human readable."
The commit: f86844d#diff-0f59f6b531470706ceb26dfd437a9f532268c7db41145bbbc60c48d566bbc633

Describe the solution you'd like
Allow a way to show the human readable value of custom protobuf messages so that wallet users can verify what they are signing before approving.

Describe alternatives you've considered
Noticed that Osmosis custom messages such as type: osmosis/lockup/begin-unlock-period-lock do show human readable value with a schema as {"owner":"osmo123...","ID":"123457"}
Perhaps there is a workaround there, or perhaps they are using Amino encoding.

Additional context
Add any other context or screenshots about the feature request here.
image

image

@paplco paplco added the enhancement New feature or request label Jan 12, 2022
@chismo950
Copy link

I also wonder how to use type, not type_url, do you know any documentation about it?

@mhagel
Copy link

mhagel commented Nov 30, 2022

@Thunnini is this issue still active?

It would be nice to see human-readable protobuf message details without forcing the amino API.

@frumioj
Copy link

frumioj commented Nov 30, 2022

See equivalent for Ethereum/Metamask at EIP 1138 ethereum/EIPs#1138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants