Allow deepEqual fonction to be configured globally (4.x.x branch)

[forty]

Identical change as #1551 on 4.x.x branch

[forty]

Thanks @43081j for the review!

Happy new year to the Chai team and congrats on the v5 release 👏

I assume you must be busy handling "after sales" of the release, but do you think this MR could be merged and released any time soon?

Thanks!

[koddsson]

Let me see if I can publish this without breaking everything 😅

[koddsson]

Should be out there now in v4.4.0

[forty]

Awesome, thanks a lot @koddsson ! Everything looks good on my side (and you haven't override the latest tag ;) )

[koddsson]

and you haven't override the latest tag ;)

Oh but I did for a couple of minutes 😭

[link2xt]

This broke our CI: deltachat/deltachat-core-rust#5153

Fails with:

> [email protected] test:mocha
> mocha -r esm node/test/test.js --growl --reporter=spec --bail --exit

notification support prerequisites not installed... cannot enable!

/home/runner/work/deltachat-core-rust/deltachat-core-rust/node_modules/chai/lib/chai/assertion.js:69
    flag(this, 'eql', config.deepEqual ?? util.eql);
                                        ^

SyntaxError: Invalid or unexpected token
    at Module._extensions..js (node:internal/modules/cjs/loader:1414:10)
Error: Process completed with exit code 1.

CI runs node.js 18.19.0.

[forty]

Are you sure of your nodejs version? Nullish Coalescing operator ?? exists since nodejs 14.

$ podman run -it --rm node:18.19.0 -e 'console.log(undefined ?? "ok")'
ok

[forty]

Ok, I found the issue in your setup standard-things/esm#909

Looks like you are using this "esm" package, which have been dead for a while, last publish was 5 years ago and the repo is archived, so I would not expect a fix 😬

[link2xt]

Ok, I found the issue in your setup standard-things/esm#909

Looks like you are using this "esm" package, which have been dead for a while, last publish was 5 years ago and the repo is archived, so I would not expect a fix 😬

Thanks, I filed an issue to track this at deltachat/deltachat-core-rust#5156
For now just pinned chai to the last version that worked.