Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop GenerateExportHeader and WriteCompilerDetectionHeader #113

Open
Tachi107 opened this issue Oct 5, 2022 · 2 comments
Open

Drop GenerateExportHeader and WriteCompilerDetectionHeader #113

Tachi107 opened this issue Oct 5, 2022 · 2 comments

Comments

@Tachi107
Copy link

Tachi107 commented Oct 5, 2022

GenerateExportHeader doesn't do anything special that can't already be known before building the project (i.e. a regular, static header file has no disadvantages over it), and it creates issues in MultiArch environments, as the generated export header is compiler dependant (related to #35). See zyantific/zycore-c#41 for an example.

WriteCompilerDetectionHeader already generates issues in cmake-init, as it isn't available in CMake versions older than 3.2; at the same time, the module got removed in CMake 3.20.

@scheibel
Copy link
Member

scheibel commented Feb 5, 2023

Thanks for the suggestion.
I'm glad C++ and CMake evolved to get rid of those headers and I'm planning to remove the need for them.
Maybe we can get rid of pre-compiled feature headers altogether.

@scheibel
Copy link
Member

Just for cross-reference: we encountered this issue before: cginternals/glbinding#333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants