on_done is not called with on_start args

[kalkschneider]

Hello Cristian,

In your last release you changed the way the callback functions work. The return values of on_start are not passed to on_done as input arguments anymore. I hope you didn't do it on purpose, that makes it hard to close open connections if a worker has finished.

Your old code:

args = params.on_start(worker_info)
params.on_done(stage_status, *args)

Your new code:

f_kwargs = self.on_start(**on_start_kwargs)
on_done_kwargs = {}
done_resp = self.on_done(**on_done_kwargs)

[cgarciae]

Hey @kalkschneider!

Let me check. 😮 I think I have tests for this.

[cgarciae]

Fixed in version 0.2.5.

[cgarciae]

@kalkschneider Thanks for reporting the issue!
It was a serious bug resulting from the recent refactor.

BTW: Version 0.2 brought small modifications to how these additional arguments are handled, instead of *args we are now using **kwargs which means that on_start now should return a dictionary instead of a tuple. Take a look at the new documentation for the behavior: https://cgarciae.github.io/pypeln/advanced/#resource-management