Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static typing with e.g. mypy #45

Open
jarppiko opened this issue Nov 2, 2022 · 1 comment · May be fixed by #49
Open

Static typing with e.g. mypy #45

jarppiko opened this issue Nov 2, 2022 · 1 comment · May be fixed by #49
Labels
code quality Improvement of code quality help wanted Extra attention is needed

Comments

@jarppiko
Copy link

jarppiko commented Nov 2, 2022

Hello,

I noticed cfv does not use type hints. Type hints and type checkers such as mypy are great aids for making robust code. Strongly recommended.

Cheers,
J

@lxp
Copy link
Member

lxp commented Nov 8, 2022

I also think that adding type hints is a great idea. If anyone wants to give it a try, I would be happy to support it.

@lxp lxp added code quality Improvement of code quality help wanted Extra attention is needed labels Nov 8, 2022
@mkoppmann mkoppmann linked a pull request Dec 16, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improvement of code quality help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants