Add support for download function in web
#2230
Conversation
mbfakourii
changed the title
download function in web
|
This looks interesting, thanks! I read about We will need some tests and and likely an example. |
|
By further examining the web request, I realized that we use The problem of high memory is solved. thank you for checking again |
mbfakourii
changed the title
download function in webdownload function in web
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
|
Could you move on with the new structure of the code and add tests? |
# Conflicts: # dio/lib/src/adapters/browser_adapter.dart # dio/lib/src/dio/dio_for_browser.dart
changes are applied. thank you for checking again |
dio/lib/src/options.dart
Outdated
| /// Get blob url. | ||
| /// Only work in web. |
There was a problem hiding this comment.
The description seems to lack explanation.
There was a problem hiding this comment.
I made changes to the description
| if (options.responseType == ResponseType.blobUrl) { | ||
| completer.complete( | ||
| ResponseBody.fromString( | ||
| Url.createObjectUrl(xhr.response), |
There was a problem hiding this comment.
Could you reuse other fields by constructing the ResponseBody with the unnamed constructor?
There was a problem hiding this comment.
The ResponseBody with the unnamed constructor requires steam, we have a url string !
|
changes are applied. thank you for checking again |
|
Please add tests. |
I tried to add the test, but I get the following error PS C:\Users\aaa\bbb\dio\plugins\web_adapter> flutter test
Error on line 10, column 3 of dart_test.yaml: Unknown platform "chrome".
╷
10 │ chrome:
│ ^^^^^^
╵or PS C:\Users\aaa\bbb\dio\plugins\web_adapter\test> flutter test .\browser_test.dart
Changing current working directory to: C:\Users\aaa\bbb\dio\plugins\web_adapter
Error on line 10, column 3 of dart_test.yaml: Unknown platform "chrome".
╷
10 │ chrome:
│ ^^^^^^
╵And I commented the contents of the "dart_test.yaml" file and run the tests again PS C:\Users\aaa\bbb\dio\plugins\web_adapter> flutter test
No tests ran.
No tests were found.or PS C:\Users\aaa\bbb\dio\plugins\web_adapter\test> flutter test .\browser_test.dart
Changing current working directory to: C:\Users\aaa\bbb\dio\plugins\web_adapter
No tests ran.
No tests were found. |
Try to set up the test like the GitHub workflow of this library. |
…orBrowser # Conflicts: # plugins/web_adapter/lib/src/adapter.dart # plugins/web_adapter/lib/src/dio_impl.dart
Test added |
New Pull Request Checklist
mainbranch to avoid conflicts (via merge from master or rebase)CHANGELOG.mdin the corresponding packageAdditional context and info
In this PR, download support was added to dio with the help of
Blobfiles.Note: There is no need to send
savePathon the web and it can be empty.