-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure DS website's information architecture #656
Conversation
- Removes main nav and moves all nav elements to left-hand sidebar - Changes nav categories - Removes four netlify cms collections that were based on categories and replaces them with a single one called "Pages" - Adds a netlify cms collection called "Navigation" that lets users edit the side nav - Moves special pages like the homepage and the help page to a new collection called "Special pages" - Updates tests and Jekyll/netlify metadata files as appropriate https://GHE/CFPB/el-camino/issues/251
I moved all the pages to a new folder so before merging this PR I'll manually remediate recent content conflicts. |
View a preview of the Design System website with your changes using the following link. Built with commit 31d59ab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update m-list_item__tertiary
and fix the empty unordered list it sometimes contains.
A few more general thoughts for beyond this PR probably:
- What if we put the sidenav on all pages, including the homepage? If not, why not?
- What if when you hovered over the sidenav it showed a little pencil icon like the edit this page buttton, and when you clicked that icon it brought you to the edit sidenav page?
🤯 🤯 🤯 |
It's very, very difficult to check a string for emptiness with Liquid. Shopify/liquid#223 (comment)
Otherwise there's a space between the last word and the final period. I could just put the last anchor tag on its own line but I don't want to alienate it and make it feel uncomfortable.
Thanks @anselmbradford. I fixed things and added the side nav to the homepage. Adding an edit button to the side nav is a great idea but beyond the scope of this PR. |
This PR restructures the site's navigation and moves every page into its new category. There's no longer a nav in the header, it's all in the sidebar now. It's also editable via the CMS to let users place pages exactly where they want instead of everything getting listed alphabetically.
We used to have a netlify cms collection for every category but IMHO that's silly so I deleted them all and created a new collection called
pages
that houses every page.Changes
pages/
.Testing
yarn test:browser
should passside-navigation.yml
file doesn't exist in this repo's master branch. You can run the site locally to preview it.Screenshots
Notes
Todos
Checklist
Testing checklist
Browsers
Accessibility
Other