Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong response status code if UID doesn't exist #49

Open
NadChel opened this issue Feb 4, 2024 · 4 comments
Open

Wrong response status code if UID doesn't exist #49

NadChel opened this issue Feb 4, 2024 · 4 comments

Comments

@NadChel
Copy link

NadChel commented Feb 4, 2024

Hey! I checked your OpenAPI, and it seems to be incorrect. I tried a few endpoints, and in all cases I got a 500. For example, I hit:

I realize it's a volunteer project so I don't have any complaints, but I figured you should be informed 🙂

@kiwdave
Copy link

kiwdave commented Nov 13, 2024

where did you obtain the uid? for example: https://stapi.co/api/v1/rest/animal?uid=ANMA0000028270

@NadChel
Copy link
Author

NadChel commented Nov 14, 2024

where did you obtain the uid? for example: https://stapi.co/api/v1/rest/animal?uid=ANMA0000028270

I don't believe 500 is an appropriate status code if no record with a given id (e.g. 1) exists

@NadChel NadChel changed the title OpenAPI is invalid Wrong response status code if UID doesn't exist Nov 14, 2024
@kiwdave
Copy link

kiwdave commented Nov 14, 2024

gotcha, yeah 404 would be more appropriate. sorry, should have read title not just description

@NadChel
Copy link
Author

NadChel commented Nov 14, 2024

Don't worry, I edited the title just a few hours back. It used to be more generic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants